Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect python spec name for release wheels workflow #177

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

RobertIndie
Copy link
Member

There is an error when building the wheel for python12:

Dockerfile:35
--------------------
  33 |     ENV PYTHON_LIBRARIES   /opt/python/${PYTHON_SPEC}/lib/python${PYTHON_VERSION}
  34 |     
  35 | >>> RUN pip3 install pyyaml
  36 |     
  37 |     ADD .build/dependencies.yaml /
--------------------

More context: https://github.com/apache/pulsar-client-python/actions/runs/7246274042/job/19737879474#step:6:237

The python spec name is incorrect in the github release wheels workflow. These are all specs in the manylinux2014:

[root@82c96c919b6f /]# cd /opt/python/
[root@82c96c919b6f python]# ll
total 0
lrwxrwxrwx 1 root root 30 Dec 18 19:58 cp310-cp310 -> /opt/_internal/cpython-3.10.13
lrwxrwxrwx 1 root root 29 Dec 18 19:57 cp311-cp311 -> /opt/_internal/cpython-3.11.7
lrwxrwxrwx 1 root root 29 Dec 18 19:57 cp312-cp312 -> /opt/_internal/cpython-3.12.1
lrwxrwxrwx 1 root root 29 Dec 18 19:57 cp36-cp36m -> /opt/_internal/cpython-3.6.15
lrwxrwxrwx 1 root root 29 Dec 18 19:57 cp37-cp37m -> /opt/_internal/cpython-3.7.17
lrwxrwxrwx 1 root root 29 Dec 18 19:57 cp38-cp38 -> /opt/_internal/cpython-3.8.18
lrwxrwxrwx 1 root root 29 Dec 18 19:57 cp39-cp39 -> /opt/_internal/cpython-3.9.18
lrwxrwxrwx 1 root root 33 Dec 18 19:58 pp310-pypy310_pp73 -> /opt/_internal/pp310-pypy310_pp73
lrwxrwxrwx 1 root root 31 Dec 18 19:58 pp37-pypy37_pp73 -> /opt/_internal/pp37-pypy37_pp73
lrwxrwxrwx 1 root root 31 Dec 18 19:58 pp38-pypy38_pp73 -> /opt/_internal/pp38-pypy38_pp73
lrwxrwxrwx 1 root root 31 Dec 18 19:58 pp39-pypy39_pp73 -> /opt/_internal/pp39-pypy39_pp73

This PR fixes the incorrect spec name for python12.

@RobertIndie RobertIndie added the bug Something isn't working label Dec 19, 2023
@RobertIndie RobertIndie added this to the 3.4.0 milestone Dec 19, 2023
@RobertIndie RobertIndie self-assigned this Dec 19, 2023
@RobertIndie RobertIndie merged commit bf8524a into apache:main Dec 19, 2023
7 checks passed
@RobertIndie RobertIndie deleted the fix-release-wheels branch December 19, 2023 23:29
RobertIndie added a commit that referenced this pull request Dec 20, 2023
There is an error when building the wheel for python12:
```
Dockerfile:35
--------------------
  33 |     ENV PYTHON_LIBRARIES   /opt/python/${PYTHON_SPEC}/lib/python${PYTHON_VERSION}
  34 |
  35 | >>> RUN pip3 install pyyaml
  36 |
  37 |     ADD .build/dependencies.yaml /
--------------------
```
More context: https://github.com/apache/pulsar-client-python/actions/runs/7246274042/job/19737879474#step:6:237

The python spec name is incorrect in the github release wheels workflow. These are all specs in the manylinux2014:
```
[root@82c96c919b6f /]# cd /opt/python/
[root@82c96c919b6f python]# ll
total 0
lrwxrwxrwx 1 root root 30 Dec 18 19:58 cp310-cp310 -> /opt/_internal/cpython-3.10.13
lrwxrwxrwx 1 root root 29 Dec 18 19:57 cp311-cp311 -> /opt/_internal/cpython-3.11.7
lrwxrwxrwx 1 root root 29 Dec 18 19:57 cp312-cp312 -> /opt/_internal/cpython-3.12.1
lrwxrwxrwx 1 root root 29 Dec 18 19:57 cp36-cp36m -> /opt/_internal/cpython-3.6.15
lrwxrwxrwx 1 root root 29 Dec 18 19:57 cp37-cp37m -> /opt/_internal/cpython-3.7.17
lrwxrwxrwx 1 root root 29 Dec 18 19:57 cp38-cp38 -> /opt/_internal/cpython-3.8.18
lrwxrwxrwx 1 root root 29 Dec 18 19:57 cp39-cp39 -> /opt/_internal/cpython-3.9.18
lrwxrwxrwx 1 root root 33 Dec 18 19:58 pp310-pypy310_pp73 -> /opt/_internal/pp310-pypy310_pp73
lrwxrwxrwx 1 root root 31 Dec 18 19:58 pp37-pypy37_pp73 -> /opt/_internal/pp37-pypy37_pp73
lrwxrwxrwx 1 root root 31 Dec 18 19:58 pp38-pypy38_pp73 -> /opt/_internal/pp38-pypy38_pp73
lrwxrwxrwx 1 root root 31 Dec 18 19:58 pp39-pypy39_pp73 -> /opt/_internal/pp39-pypy39_pp73
```

This PR fixes the incorrect spec name for python12.

(cherry picked from commit bf8524a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants